feat: Increase specificity of WebSocket.readyState #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
cc @jbzd |
|
@microsoft-github-policy-service agree company="EverCommerce" |
Bashamega
suggested changes
Aug 7, 2025
| @@ -36690,7 +36690,7 @@ interface WebSocket extends EventTarget { | |||
| * | |||
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebSocket/readyState) | |||
| */ | |||
| readonly readyState: number; | |||
| readonly readyState: typeof WebSocket.CONNECTING | typeof WebSocket.OPEN | typeof WebSocket.CLOSING | typeof WebSocket.CLOSED; | |||
There was a problem hiding this comment.
Suggested change
| readonly readyState: typeof WebSocket.CONNECTING | typeof WebSocket.OPEN | typeof WebSocket.CLOSING | typeof WebSocket.CLOSED; | |
| readonly readyState: 0 | 1 | 2 | 3; |
This is more performant and compiles to the same output. Using the WebSocket.CONNECTING | ... approach adds unnecessary complexity without functional benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDN docs say this is strictly one of the four values that we already have references to as
WebSocket.CONNECTINGetc.